Retyped the libSession wrapper in preparation of the 1.3.0 changes #1040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @mpretty-cyro do you still need this PR? |
Ah nope, I'll close it now |
|
Superseded by session-foundation/libsession-util-android#4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to properly support libc++18 (and clang-19) no longer support the
ustring/ustring_viewconvention we were using and as such we were forced to update a number of our libraries to replace this convention with a more standard approach (we settled onstd::vector<unsigned char>andstd::span<const unsigned char>)This "retyping" also affected
libSessionwhich means there are a number of breaking changes in the next version made as part of session-foundation/libsession-util#26This PR updates the libSession wrapper code to support these changes
Note: This shouldn't be merged until after session-foundation/libsession-util#26 has been merged